rds_instance: Set no_log=False on force_update_password #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuman
approved these changes
Sep 30, 2020
|
@jillr mind giving this one a quick review - be good to remove the warning before the next release. |
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Nov 10, 2020
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
rds_instance: Set no_log=False on force_update_password
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
rds_instance: Set no_log=False on force_update_password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Because force_update_password doesn't contain sensitive information (but matches the pattern "password") we need to explicitly set no_log=False to avoid a warning for users.
ISSUE TYPE
COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
fixes: #241